search

QSD-Group / QSDsan

Quantitative Sustainable Design (QSD) of sanitation and resource recovery systems.
https://qsdsan.com
Other
30 stars 12 forks source link

BSM1 test failed #67

Closed yalinli2 closed 2 years ago

yalinli2 commented 2 years ago

See here: https://github.com/QSD-Group/QSDsan/runs/5955204241?check_suite_focus=true

Looks like it's related to the S_O and S_N2 without VolumeLiquid._extrapolation_min (thermo/utils/t_dependent_property.py, line 3659) in thermo==0.2.19

yalinli2 commented 2 years ago

This has been fixed in 5dc95a8cc09c028fa9de4365b60adfff2d5b1d9e