QSD-Group / QSDsan

Quantitative Sustainable Design (QSD) of sanitation and resource recovery systems.
https://qsdsan.com
Other
30 stars 14 forks source link

Added answers to designing chlorination unit. #68

Closed philthestone closed 2 years ago

philthestone commented 2 years ago

Some updates for the chorination_unit.ipynb tutorial: Answers were added for the open questions (except Q10. I'll update this ASAP, but let's just assume some generic values there until I know more.) and some minor changes were added.

codecov[bot] commented 2 years ago

Codecov Report

Merging #68 (5be811d) into main (746de72) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #68   +/-   ##
=======================================
  Coverage   72.10%   72.10%           
=======================================
  Files          78       78           
  Lines       11997    11997           
  Branches     1372     1372           
=======================================
  Hits         8651     8651           
  Misses       2978     2978           
  Partials      368      368           
Flag Coverage Δ
unittests 72.10% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 746de72...5be811d. Read the comment docs.

yalinli2 commented 2 years ago

Thanks @philthestone for the contribution and notes, I've look at your notes and changes in detail in the next couple of days and make updates accordingly.

I'll keep this PR open until I finish the updates.