QSD-Group / QSDsan

Quantitative Sustainable Design (QSD) of sanitation and resource recovery systems.
https://qsdsan.com
Other
30 stars 12 forks source link

Merge updated Biogenic Refinery, Eco-San, and Reclaimer into `beta` #75

Closed yalinli2 closed 2 years ago

yalinli2 commented 2 years ago

Finally it's time to merge in the Gates units! I'm sending the pull request to the beta branch just to add a layer of safety before having it on main, feel free to approve & merge in if @haclohman you see no problems, thanks!

codecov[bot] commented 2 years ago

Codecov Report

Merging #75 (00d469e) into beta (e775df6) will decrease coverage by 4.29%. The diff coverage is 25.64%.

@@            Coverage Diff             @@
##             beta      #75      +/-   ##
==========================================
- Coverage   71.63%   67.34%   -4.30%     
==========================================
  Files          77       82       +5     
  Lines       12393    13660    +1267     
  Branches     1423     1555     +132     
==========================================
+ Hits         8878     9199     +321     
- Misses       3137     4083     +946     
  Partials      378      378              
Flag Coverage Δ
unittests 67.34% <25.64%> (-4.30%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
qsdsan/_sanunit.py 78.19% <0.00%> (ø)
qsdsan/utils/model_eval.py 55.07% <ø> (ø)
qsdsan/sanunits/_toilets.py 71.55% <20.48%> (-8.70%) :arrow_down:
qsdsan/sanunits/_septic_tank.py 20.93% <20.93%> (ø)
qsdsan/sanunits/_sludge_pasteurization.py 21.05% <21.05%> (ø)
qsdsan/sanunits/_biogenic_refinery.py 23.51% <23.51%> (ø)
qsdsan/sanunits/_reclaimer.py 26.78% <26.78%> (ø)
qsdsan/sanunits/_eco_san.py 30.68% <30.68%> (ø)
qsdsan/sanunits/__init__.py 100.00% <100.00%> (ø)
qsdsan/sanunits/_sludge_thickening.py 82.45% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us.