search

QSD-Group / QSDsan

Quantitative Sustainable Design (QSD) of sanitation and resource recovery systems.
https://qsdsan.com
Other
30 stars 12 forks source link

Add `ImpactIndicator` and `ImpactItem` to `Flowsheet` #76

Closed yalinli2 closed 2 years ago

yalinli2 commented 2 years ago

This would enable the use of impact item objs with the same ID but different properties

yalinli2 commented 2 years ago

Thinking twice, it might be better to keep just one registry for ImpactIndicator and one for ImpactItem - this would make sure that when multiple systems are evaluated at the same time, consistent values are used, see this issue on the private repo: https://github.com/QSD-Group/EXPOsan-private/issues/7

I'll update QSDsan to raise an error if ImpactItem with the same ID is created with different characterization factor values, however, it might also be good to add an env setting like CONSISTENT_IMPACT_ITEM to allow different CF values.

yalinli2 commented 2 years ago

Done in ef8a9e761517883d2f11329bc31e831e6c11831b!