Closed yalinli2 closed 2 years ago
Merging #78 (a47f539) into stable (746de72) will increase coverage by
3.47%
. The diff coverage is88.13%
.:exclamation: Current head a47f539 differs from pull request most recent head 94219df. Consider uploading reports for the commit 94219df to get more accurate results
@@ Coverage Diff @@
## stable #78 +/- ##
==========================================
+ Coverage 72.10% 75.58% +3.47%
==========================================
Files 78 82 +4
Lines 11997 13769 +1772
Branches 1372 1581 +209
==========================================
+ Hits 8651 10407 +1756
+ Misses 2978 2943 -35
- Partials 368 419 +51
Flag | Coverage Δ | |
---|---|---|
unittests | 75.58% <88.13%> (+3.47%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
qsdsan/_sanstream.py | 68.65% <0.00%> (-1.72%) |
:arrow_down: |
qsdsan/_simple_tea.py | 88.68% <ø> (+1.35%) |
:arrow_up: |
qsdsan/equipments/__init__.py | 100.00% <ø> (ø) |
|
qsdsan/equipments/_aeration.py | 74.72% <ø> (ø) |
|
qsdsan/equipments/_column.py | 100.00% <ø> (ø) |
|
qsdsan/equipments/_electrode.py | 93.61% <ø> (ø) |
|
qsdsan/equipments/_machine.py | 100.00% <ø> (ø) |
|
qsdsan/equipments/_membrane.py | 56.25% <ø> (ø) |
|
qsdsan/processes/_aeration.py | 64.06% <ø> (ø) |
|
qsdsan/sanunits/_activated_sludge_process.py | 90.33% <ø> (ø) |
|
... and 86 more |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
Looks good, merging in!
Couldn't do this locally as I removed some of the git refs when I was doing some cleanup, and also because of the large number of new unit operations/systems added in this release.