fix bugs with locking phase and initializing energies

QSD-Group / QSDsan

Quantitative Sustainable Design (QSD) of sanitation and resource recovery systems.

https://qsdsan.com

Other

30 stars 12 forks source link

fix bugs with locking phase and initializing energies #82

Closed yoelcortes closed 1 year ago

yoelcortes commented 2 years ago

Small bug fixes for new BioSTEAM, Thermosteam updates.

Thanks!

yalinli2 commented 2 years ago

Thanks @yoelcortes ! But for some reason the tests couldn't pass (they passed locally) and appears to be not pulling in the most recent biosteam/thermosteam (although I updated the qsdsan branches of both). Not sure what's going on here, so I put in some temporary fix so that it will pass either way, I'll leave this open until I figure out why

yalinli2 commented 1 year ago

I can finally close this PR (though it couldn't be merged as the patch branch is outdated now) as the remote tests are passing now (https://github.com/QSD-Group/QSDsan/commit/dd07bc5cee52d3a5332e10166697f09d515c54c8)