search

QSD-Group / QSDsan

Quantitative Sustainable Design (QSD) of sanitation and resource recovery systems.
https://qsdsan.com
Other
30 stars 14 forks source link

Remove unused DomainError in _components.py #88

Closed jiananf2 closed 2 years ago

jiananf2 commented 2 years ago

Thermosteam recently removed DomainError from thermosteam/exceptions.py.

codecov[bot] commented 2 years ago

Codecov Report

Merging #88 (3b5cfb6) into main (ecafe08) will decrease coverage by 0.00%. The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #88      +/-   ##
==========================================
- Coverage   73.45%   73.45%   -0.01%     
==========================================
  Files          84       84              
  Lines       14495    14494       -1     
  Branches     1584     1584              
==========================================
- Hits        10647    10646       -1     
  Misses       3412     3412              
  Partials      436      436
Flag Coverage Δ
unittests 73.45% <ø> (-0.01%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
qsdsan/_components.py 79.87% <ø> (-0.07%) :arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

yalinli2 commented 2 years ago

Cool! Thanks @jiananf2 for sending the PR!

Just a note that there is a qsdsan branch for both biosteam and thermosteam, I update those branches periodically after making sure that updates in biosteam/thermsteam are compatible with qsdsan. But helping me to maintain qsdsan by sending PRs like this is much appreciated!