QSD-Group / QSDsan

Quantitative Sustainable Design (QSD) of sanitation and resource recovery systems.
https://qsdsan.com
Other
30 stars 12 forks source link

Minor updates `SanUnit` attributes for LCA calculation #97

Closed yalinli2 closed 1 year ago

yalinli2 commented 1 year ago

list is easier to manipulate than the previous tuple

codecov[bot] commented 1 year ago

Codecov Report

Merging #97 (a0ee509) into main (e98cf82) will decrease coverage by 0.21%. The diff coverage is 93.75%.

@@            Coverage Diff             @@
##             main      #97      +/-   ##
==========================================
- Coverage   75.02%   74.80%   -0.22%     
==========================================
  Files          86       86              
  Lines       14874    14874              
  Branches     1612     1612              
==========================================
- Hits        11159    11127      -32     
- Misses       3260     3291      +31     
- Partials      455      456       +1     
Flag Coverage Δ
unittests 74.80% <93.75%> (-0.22%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
qsdsan/sanunits/_anaerobic_reactors.py 78.52% <50.00%> (ø)
qsdsan/_sanunit.py 77.54% <81.25%> (-1.80%) :arrow_down:
qsdsan/_lca.py 68.67% <100.00%> (ø)
qsdsan/sanunits/_biogenic_refinery.py 94.28% <100.00%> (ø)
qsdsan/sanunits/_eco_san.py 97.02% <100.00%> (ø)
qsdsan/sanunits/_electrochemical_cell.py 100.00% <100.00%> (ø)
qsdsan/sanunits/_lagoon.py 88.63% <100.00%> (ø)
qsdsan/sanunits/_reclaimer.py 94.80% <100.00%> (ø)
qsdsan/sanunits/_sedimentation.py 91.81% <100.00%> (ø)
qsdsan/sanunits/_septic_tank.py 93.75% <100.00%> (ø)
... and 8 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.