Closed alphaville closed 11 months ago
@jamie-54 since there are lots of changes in this PR, can you review it yourself before we merge it?
A general comment: I'm not sure whether we want to address this now or later, but the class RC
does not only read the values from the RC, but also sends data from the Pi to ESP32, which is none of its business. If we can't fix this now, let's create an issue - @gunturiCM
A general comment: I'm not sure whether we want to address this now or later, but the class
RC
does not only read the values from the RC, but also sends data from the Pi to ESP32, which is none of its business. If we can't fix this now, let's create an issue - @gunturiCM
To avoid keeping this open for too long, let's take care of the final details (documentation and some final checks). I'll open an issue about this
A general comment: I'm not sure whether we want to address this now or later, but the class
RC
does not only read the values from the RC, but also sends data from the Pi to ESP32, which is none of its business. If we can't fix this now, let's create an issue - @gunturiCMTo avoid keeping this open for too long, let's take care of the final details (documentation and some final checks). I'll open an issue about this
The opened issue is #109, this and #110 are expected to be addressed in #111.
Let's merge this now and we'll come back to it for a mild refactoring later. If anything comes up, let us create an issue.
About:
Tests
Hardware tests done