Closed Yuanbwcx closed 6 months ago
jamie-54
commented
7 months ago I've added a few comments. By looking at this it seems you want to make the EvoSensor class as similar to TimeOfFlightSensor to work in main.py which makes sense to start with. Later we might want to change the way data is saved at the end.
I think its important to test changes on the quadcopter before merging as well.
jamie-54
commented
7 months ago I think PR #202 Covers issue #188 and since we are doing a new altitude hold with more sensors I don't think there is much need for this PR? What's everyone else's thoughts?
Yuanbwcx
commented
7 months ago I think PR #202 Covers issue #188 and since we are doing a new altitude hold with more sensors I don't think there is much need for this PR? What's everyone else's thoughts?
Do you mean that we shall close this PR and make changes about the new TOF sensor in PR #202 ?
jamie-54
commented
7 months ago I think PR #202 Covers issue #188 and since we are doing a new altitude hold with more sensors I don't think there is much need for this PR? What's everyone else's thoughts?
Do you mean that we shall close this PR and make changes about the new TOF sensor in PR #202 ?
Yea because we are using the new ToF sensor in #202 to read and save the distance is from the ground.
Yuanbwcx
commented
7 months ago I think PR #202 Covers issue #188 and since we are doing a new altitude hold with more sensors I don't think there is much need for this PR? What's everyone else's thoughts?
Do you mean that we shall close this PR and make changes about the new TOF sensor in PR #202 ?
Yea because we are using the new ToF sensor in #202 to read and save the distance is from the ground.
Good to me
Yuanbwcx
commented
6 months ago Should we close this now since I uploaded all the changes to PR #202
Main Changes
Replace old TOF sensor with Evo TOF sensor in main file and add cache to Evo sensor.
Issues
Closes #188
Tests
Not tested yet.