Closed alphaville closed 1 year ago
@jamie-54 can you have a look and make sure that everything makes sense and that it works on the quadcopter? I haven't really changed any functionality; I just reorganised the code.
Hi looks good and everything makes sense I'll test it on the hardware tomorrow just to be sure.
Just wondering do you want to keep setGainsFromRcTrimmers
in the main.cpp
or move it somewhere else?
I get that it doesn't really have a clear file that it belongs to.
@jamie-54 this actually is part of the loop
. I just moved this functionality to setGainsFromRcTrimmers
for loop
to be more readable. I don't think it belongs to another file.
@jamie-54 this actually is part of the
loop
. I just moved this functionality tosetGainsFromRcTrimmers
forloop
to be more readable. I don't think it belongs to another file.
Oh yea I see what's happening now, looks good
@jamie-54 I'm merging this now, but can you check whether everything still works (it should). I've made some very minor changes (see last commit).
@jamie-54 I'm merging this now, but can you check whether everything still works (it should). I've made some very minor changes (see last commit).
No problem
Main Changes
averageQuaternion
)logSerial
,setupBuzzer
,buzz
andwaitForPiSerial
go to utilconfig.cpp
Serial.print
tologSerial
BZZZ_VERBOSITY
toBZZZ_LOGGING_LEVEL
Associated Issues
DevOps
Before we merge this:
dev
firstdev
intofeature/41-tidy-up-main
initAngularVelocity
to AHRS (as we've done withaverageQuaternion
here)