search

QUItCoding / qnanopainter

Library for implementing OpenGL accelerated Qt (Quick) C++ UI components.
http://quitcoding.com
Other
405 stars 79 forks source link

Don't alter QT_NO_{DEBUG,WARNING,INFO}_OUTPUT in include.pri #61

Closed rburchell closed 3 years ago

rburchell commented 3 years ago

It's great that you have a .pri file that enables easy embedding into other projects. But I think it's a bit hostile that this .pri alters "global" defines that may affect the rest of the project unexpectedly. In particular, QTNO{WARNING,DEBUG,INFO}_OUTPUT I think should not be changed by the .pri, but set by the including project.

The reason I am filing this is I had log output disabled for an entire library that I linked qnanopainter into, and it took me quite some time to track down the reason why I was no longer seeing useful logging output from my own code :)

QUItCoding commented 3 years ago

True, removed those defines from the include.pri with the above commit. Thanks!