search

QUT-Digital-Observatory / coordination-network-toolkit

A small command line tool and set of functions for studying coordination networks in Twitter and other social media data.
MIT License
72 stars 14 forks source link

Wrap db usage in try/finally in preprocessing, accept float timestamps #6

Closed betsybookwyrm closed 3 years ago

betsybookwyrm commented 3 years ago

@SamHames just wanted you to quickly check this isn't going to break anything.

I'm mostly concerned about the int -> float change in pre-processing CSVs. I think a lot of things will generate timestamps with milliseconds?

SamHames commented 3 years ago

I can't think of any way that it would break things. Only issue is if they give a timestamp that is a count of milliseconds instead of a fractional second. Things will still work, it's just that the time_window functionality will be with reference to those units.

betsybookwyrm commented 3 years ago

The readme does specify timestamp should be seconds, it just doesn't say it has to be an integer, so I think that's sufficient about the danger of people providing a milliseconds value rather than a seconds value.