search

QUTlib / citation-import

EPrints plugins for importing citation counts from 3rd party web servicse
GNU General Public License v2.0
3 stars 1 forks source link

Remove parse retry functionality #5

Closed MrkGrgsn closed 11 years ago

MrkGrgsn commented 11 years ago

Currently the CitationService plugin makes multiple attempts to retrieve a parseable response from the web service. Not being able to recall the requirements this arose from, I think it is probable a redundant attempt to make it more robust. My reasoning is thus:

  1. Network level errors, e.g., transmission error leading to malformed HTTP message, should be handled by the net_retry functionality. This appears to be largely the existing situation.
  2. A malformed HTTP message body from a web service is a bug in the web service and unlikely to be fixed after a few minutes of waiting.
  3. An otherwise unparseable message body indicates a bug with the plugin that is not going to be fixed by waiting and trying again.

I propose removing the parse-retry functionality to simplify the flow of CitationService::process_eprints() and treat parsing failures as errors that cause the plugin to cease execution. Comments welcomed!

MrkGrgsn commented 11 years ago

I'd like to do this at the same time I deal with https://github.com/QUTlib/citation-import/issues/4

MrkGrgsn commented 11 years ago

Closed by 1e290500cfdf9b8d91ce813738c905d42dd0664e 79525de92c2322d4776308d62af7c9acaf1355c4 and feacc0c882c9be4c7c6305ab4bb4ba0fef8c6979