search

QUVA-Lab / e2cnn

E(2)-Equivariant CNNs Library for Pytorch
https://quva-lab.github.io/e2cnn/
Other
597 stars 75 forks source link

Fix padding in R2Conv for padding_mode other than 'zeros' #23

Closed fsherry closed 3 years ago

fsherry commented 3 years ago

In the forward pass of R2Conv, padding was applied twice if the padding mode was anything other than 'zeros', resulting in an incorrect output shape. This commit fixes the problem by deleting one of the redundant applications of the padding operation.

Signed-off-by: Ferdia Sherry fs436@cam.ac.uk

fsherry commented 3 years ago

Thanks for sharing this very useful package. While I was playing around with R2Conv, I found this small issue with the for padding with non-zeros.

Gabri95 commented 3 years ago

Hi @fsherry ,

Thanks a lot for spotting this issue and fixing it!

I am happy to read it our work is useful for you :)

I will merge this PR in a moment

Thanks, Gabriele