search

QUVA-Lab / e2cnn

E(2)-Equivariant CNNs Library for Pytorch
https://quva-lab.github.io/e2cnn/
Other
599 stars 74 forks source link

PointwiseMaxPoolAntialiased wrongly inherits .export() from parent class. #30

Closed drewm1980 closed 3 years ago

drewm1980 commented 3 years ago

While auditing e2cnn too see if the functions I need actually support .export(), I noticed that:

PointwiseMaxPoolAntialiased:

https://github.com/QUVA-Lab/e2cnn/blob/9054d1ecc7539e981ee06cba0117a09ad3b8f9a9/e2cnn/nn/modules/pooling/pointwise_max.py#L143

inherits the .export() function from PointwiseMaxPool, whereas it should be exporting ops for the antialiased version.

drewm1980 commented 3 years ago

I'm preparing a MR for this.

Gabri95 commented 3 years ago

Thanks again for reporting and fixing this! :)

Gabriele