search

QUVA-Lab / e2cnn

E(2)-Equivariant CNNs Library for Pytorch
https://quva-lab.github.io/e2cnn/
Other
599 stars 74 forks source link

Add export for PointwiseMaxPoolAntialiased. #31

Closed drewm1980 closed 3 years ago

drewm1980 commented 3 years ago

Fix for: https://github.com/QUVA-Lab/e2cnn/issues/30

First time contributor; comments are welcome.

The existing unit test for .export() was very helpful for this. The one-off locally defined class is ugly, but might be useful elsewhere; you do a lot of filtering.

Gabri95 commented 3 years ago

Hey @drewm1980

Thanks a lot for spotting this problem and for preparing this pull request!

I moved the class outside the method since, indeed, it can be useful somewhere else. For the moment I just kept it there and merged your pull request. The same can also be used for example for PointwiseAvgPoolAntialiased. I will add it later too

Thanks, Gabriele