search

QVPR / Patch-NetVLAD

Code for the CVPR2021 paper "Patch-NetVLAD: Multi-Scale Fusion of Locally-Global Descriptors for Place Recognition"
MIT License
510 stars 72 forks source link

Small issue on feature_match #72

Closed doraemon96 closed 1 year ago

doraemon96 commented 1 year ago

On the feature_match.py file there's a small bug in: https://github.com/QVPR/Patch-NetVLAD/blob/main/feature_match.py#L141 where you do:

faiss_index.search(qFeat, min(len(qFeat), max(n_values)))

I believe your intention was to restrict the search to return at most len(dbFeat) elements, which is the size of the faiss index.

faiss_index.search(qFeat, min(len(dbFeat), max(n_values)))

Very interesting paper and implementation, kudos!

Tobias-Fischer commented 1 year ago

Good catch. Could you please open a pull request so the change is properly attributed to you?