search

Qabel / qabel-desktop

(B2C) :computer: Desktop frontend of Qabel
Other
11 stars 12 forks source link

index search with email containing digits #493

Closed julianseeger closed 7 years ago

julianseeger commented 7 years ago

...fails because the phonenumber formatter gets activated and reformats them to a number...

enkore commented 7 years ago

is_email = '@' in input

julianseeger commented 7 years ago

normally, this happens before typing the @ username12345@bla.com ... as soon as you type the "12", it get's reformatted ... it's a feature, not a bug ;)

enkore commented 7 years ago

Hmm, you can't really determine from any prefix (up to an @ or "finish")whether it's an email or a phone number. Some ISPs even issued emails where the mailbox actually is a valid phone number...

audax commented 7 years ago

We probably shouldn't reformat it after we have a successful hit. Maybe not even then

julianseeger commented 7 years ago

Are the requests normalized Server side? Like if I type a phone number without language code, what happens? Otherwise we need two Inputs

mr-gosh commented 7 years ago

I was surprised that filling in a phone number without country code works at all - perhaps we do it like in my mockups... tmp_29018-identity-creator-7-955885993

julianseeger commented 7 years ago

The Idea was to Autoformat the users phone number using his locale but that is error prone and thus we need to show the result to the user so that he can fix it on failure... but that only works if we know that it actually is a phone number and not an Email address

enkore commented 7 years ago

Are the requests normalized Server side? Like if I type a phone number without language code, what happens? Otherwise we need two Inputs

They are normalized for all incoming requests according to the language specified by the client, with a fallback to German.

julianseeger commented 7 years ago

What about this: image The user can type whatever he wants but we show, what exactly we are searching for. This way, the user can adjust the input if it's not what he wanted (like adding a language prefix if neccessary) and can reach the "@" symbol without being interrupted.

audax commented 7 years ago

This looks way too reasonable, we need to find a more complicated solution.

thechauffeur commented 7 years ago

I always asked myself why some other interfaces use a drop down menu for selecting the country and actually working with (mobile) phone numbers -- and seeing the problems -- make me understand this :) Now I like the idea of the mockups but without further discussions about this (after the release) I'm still not sure about this. So we should stick with the solution we already have.