search

Qabel / qabel-desktop

(B2C) :computer: Desktop frontend of Qabel
Other
11 stars 12 forks source link

Some chat messages in a row are shown multiple times #555

Closed thechauffeur closed 7 years ago

thechauffeur commented 7 years ago

@julianseeger and I spoke about chat UI and observed this by accident. He can provide a screenshot.

thechauffeur commented 7 years ago

Maybe related to #554 (occurrence of these bugs may correlate).

julianseeger commented 7 years ago

Seems like I fixed that in https://github.com/Qabel/qabel-desktop/pull/537/files#diff-57b0be378ac499de06c3d0b829029ddaL251 With the new UI it was easy to see / reproduce. It was a race condition because on every new message, the whole chat (ALL messages) got reloaded and that was not mutexed but happened in certain circumstances multiple times at one .. thus, some messages appeared multiple times, others were cleared and never showed up...

Now, the new messages are just appended to the existing message flow and that works perfectly fine. => should be fixed once https://github.com/Qabel/qabel-desktop/pull/537 is merged