search

Qabel / qabel-desktop

(B2C) :computer: Desktop frontend of Qabel
Other
11 stars 12 forks source link

emoji fallback renderer #562

Closed julianseeger closed 7 years ago

julianseeger commented 7 years ago

makes sure threre is always something rendered (emoji or emoji with forced fitzpatrick modifier or at least the unicode emoji)

audax commented 7 years ago

No test? 🍡 🚣

julianseeger commented 7 years ago

the code is coupled to static methods ... not really testable :'(

julianseeger commented 7 years ago

test added in https://github.com/Qabel/qabel-desktop/pull/562/commits/a6d2746a695e92a5a9a3b2c62888fb90ff35f6fa PS: introduced an IconProvider interface to decouple the code from that static **** even tough it wasn't needed for the test