search

Qabel / qabel-desktop

(B2C) :computer: Desktop frontend of Qabel
Other
11 stars 12 forks source link

Files with quotation marks in filename are not synced #564

Open kikithegecko opened 7 years ago

kikithegecko commented 7 years ago

I'm using the git client from current master branch with ./gradlew client:run on a Linux machine. When putting an arbitrary file whose file name contains " into a synced folder, the file is not recognized in the Sync tab and thus not uploaded. It neither shows in the file browser. After removing the quotation marks from the filename, everything works as intended. It doesn't matter if the quotation marks are at the beginning, in the middle or at the end of the filename, behavior stays the same.

During client startup and login, I get a bunch of

[TransactionManager] ERROR de.qabel.desktop.daemon.management.DefaultTransferManager - Transaction failed: File not found de.qabel.box.storage.exceptions.QblStorageNotFound: File not found

exceptions, since I have a few files with quotation marks in their filenames in my shared folders, this might correlate. I can provide the full console output of the program if needed.

thechauffeur commented 7 years ago

I labeled this as a bug because apparently to user this looks like a bug.

IIRC the reason behind this is that we decided on supporting the minimal set of characters which are supported by all officially supported client OSs -- i.e. Windows 8.1 and above. Windows cannot handle " in filenames, therefore we do not handle these files, too.

We can discuss this again.

kikithegecko commented 7 years ago

Since prohibiting quotation marks seems like intended behaviour, I'd rather classify this as a UX bug: User should be adequately informed about prohibited characters in file names instead of silently dropping the respective files from syncs.

thechauffeur commented 7 years ago

The thing is users on supported OSs never trigger this (ux) bug.