search

Qalculate / libqalculate

Qalculate! library and CLI
https://qalculate.github.io/
GNU General Public License v2.0
1.86k stars 148 forks source link

Wrong version number in `pkg-config` file #244

Open lebensterben opened 3 years ago

lebensterben commented 3 years ago

When built from the source, the version string in libqalculate.pc file is 3.15.0 while it should be 3.16.1.

It seems that the version is not updated. https://github.com/Qalculate/libqalculate/blob/3756df436e2762d1120179a59dc41a562415f904/data/functions.xml.in#L2

hanna-kn commented 3 years ago

The version in data files are only updated when changes have been made to the file that are not fully compatible with previous versions of libqalculate (primarily when a new built-in function, requiring program code, has been added).

This is unrelated to the pkg-config version string, which are automatically set during the build process. I assume that you are using the source from git (and not libqalculate-3.16.1.tar.gz), in which case you need to run autogen.sh each time the version number has changed (when autotools build files has changed).

lebensterben commented 3 years ago

The version in data files are only updated when changes have been made to the file that are not fully compatible with previous versions of libqalculate (primarily when a new built-in function, requiring program code, has been added). ...

@hanna-kn okay now that makes sense. I'm indeed building the source git.

Would it make sense to exclude the autotools artifects from the .gitignore? Because in this way user won't accidentally use the ones from previous releases. (If they're not cleaned, git pull --rebase fails.)