QardsJs / qards

Qards is a blogging platform focused on performance and on closing the gap between content publishers and developers: https://qards.io
MIT License
239 stars 16 forks source link

Disqus latest discussions showing a UUID, instead of title of the post #84

Closed fr0der1c closed 5 years ago

fr0der1c commented 5 years ago

On disqus (https://disqus.com/home/forums/admirable-blog/), there is a UUID of each activity instead of the title of the post. Is this related to Qards?

image

ciokan commented 5 years ago

didn't find that id in the article:

curl https://blog.admirable.pro/sentry-sdk-cause-segmentation-fault/ | grep b7e19bb5-7071-55fe-9c31-500b2fb7ef84

fr0der1c commented 5 years ago

Yeah, it's not a part of the article itself. I think the problem is related to the Disqus integration of Qards. Maybe Disqus requires a title to be passed but Qards is not passing one, and due to some Javascript issue Disqus cannot get URL of the page, so they just generated a UUID as the last choice?

In the screenshot below, the first one is my blog and the second one is others' website. I think we have to pass a title parameter when using Disqus javascript. image

I found these Disqus documentations useful:

ciokan commented 5 years ago

Will have a look. Thanks!

ciokan commented 5 years ago

Fixed via: https://github.com/QardsJs/qards/commit/7b866603278fadc41d2d8a5b07eaf84e75a270aa

I pushed some cleanups lately so make sure you don't use any of the images that were uploaded with qards by default (upload your own). This includes user avatar, images in posts, galleries...any picture that you used and wasn't uploaded by you.

fr0der1c commented 5 years ago

Thanks for the notice!

fr0der1c commented 5 years ago

I pull the latest commit and seems the problem persists.

image

ciokan commented 5 years ago

Could it be that they cached the results? In the commit you can see the mistake I made but I don't know how would they grab the id now...

fr0der1c commented 5 years ago

I tried a new article and it works fine. But for articles already in Disqus, no. Maybe the title won't be updated anyway. Titles of persisting discussions can be edited on Disqus admin page though.

ciokan commented 5 years ago

So it's safe to close this issue now?

fr0der1c commented 5 years ago

Yes. Looks good to me.