search

Qarik-Group / bucc

The fastest way to get a BUCC (BOSH, UAA Credhub and Concourse)
Apache License 2.0
134 stars 46 forks source link

Add flag to install custom certs onto target #128

Closed fenech closed 6 years ago

fenech commented 6 years ago

Using bucc up with the --install-certs flag installs the certificates defined in the custom_ca_certs variable.

fenech commented 6 years ago

@rkoster I updated the pull request to remove all the extra stuff that isn't needed any more.

rkoster commented 6 years ago

@fenech Thanks!

rkoster commented 6 years ago

@fenech what do think about renaming this flag to concourse-ca-certs since it better communicates the usecase (I'm happy to make the change, just wanted your opinion)?

fenech commented 6 years ago

I went with the more general name because I thought that it better described what the flag did; as I understand, it installs additional CA certs onto the BUCC VM, and the fact that they end up propagating to Concourse is kind of a secondary (albeit intended) effect. I thought that there might be other use cases which weren't related to Concourse.

If the only useful effect of installing these CA certs is for Concourse, then I guess it makes sense to change the name to reflect that, so your suggestion makes sense.

rkoster commented 6 years ago

I could not come up with other use-cases, it might affect cpi's (for example openstack) but these already have their own flags because the expose specific properties for injecting ca certs.

will go ahead with the change. Thanks again for you input.