search

QasimWani / LeetHub

Automatically sync your leetcode solutions to your github account - top 5 trending GitHub repository
https://chrome.google.com/webstore/detail/leethub/aciombdipochlnkbpcbgdpjffcfdbggi
MIT License
3.98k stars 1.39k forks source link

Unnecessary commits for notes #135

Open SysSn13 opened 3 years ago

SysSn13 commented 3 years ago

LeetHub is uploading notes for all the problems even if it is empty. It is not a good idea to commit an empty file for every submission. To Reproduce Steps to reproduce the behavior:

Expected behavior Commit the notes only when something is written by the user or there are some new changes in the notes.

QasimWani commented 3 years ago

what do you mean notes? is it ReadMe? If so, i'm unable to reproduce it. it has been working fine so far. Please list exact procedure (and screenshots) to reproduce. Was this a one-off thing? Perhaps wait a little longer before switching/closing tabs? Have you tried reloading and resubmitting again?

SysSn13 commented 3 years ago

See this. Well It's not updated on the chrome web-store yet.

amirali-shfz commented 2 years ago

Also having this issue Screen Shot 2022-01-10 at 3 24 55 PM

QasimWani commented 2 years ago

Yeah I'm patching it up by temporarily removing the notes feature. That should solve this problem for now. Apologies for the buggy release.

sarthak1905 commented 2 years ago

Hey, has the feature been removed yet? After I made the submission today, empty Notes.md files were committed and I had to delete them on my own.

NikitaShkaruba commented 2 years ago

There's a duplicate thread https://github.com/QasimWani/LeetHub/issues/195 Still not implemented. Waiting for the release! :)

VinayLodhi1712 commented 8 months ago

Please implement this feature on chrome extensions store. The notes.md file is always committing unnecessarily. Plz remove this.

irohanrajput commented 3 months ago

is there a way to avoid committing NOTES.md & README.md ??