search

Qbicz / real-time-shape-detection

CV/AI: use ARM Mali GPU on ODROID-XU4 single-board computer + OpenCL acceleration to achieve real time shape and orientation detection of fast moving objects
28 stars 9 forks source link

Add json to project includes #5

Closed palucki closed 7 years ago

palucki commented 7 years ago

It can be used as subrepo / submodule or downloaded directly to project.

Qbicz commented 7 years ago

Do you mean json files with Hu moments?

palucki commented 7 years ago

Json.hpp only ;)

On Oct 13, 2017 21:44, "Filip Kubicz" notifications@github.com wrote:

Do you mean json files with Hu moments?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Qbicz/real-time-shape-detection/issues/5#issuecomment-336549674, or mute the thread https://github.com/notifications/unsubscribe-auth/AG9_DmkK3lB2brk0a0LFpIm318ELS0MFks5sr72qgaJpZM4P15at .

Qbicz commented 7 years ago

Then I'm for having it as a submodule ;)

Qbicz commented 7 years ago

https://github.com/nlohmann/json

palucki commented 7 years ago

Submodule is evil: https://codingkilledthecat.wordpress.com/2012/04/28/why-your-company-shouldnt-use-git-submodules/ Added as a subtree. Added with command: git subtree add --prefix PC/svm/json https://github.com/nlohmann/json.git master --squash It requires a lot of unnecessary code (tests, doc etc.) Finally decided to add only raw file in "includes" dir

Qbicz commented 7 years ago

Yeah, I've seen some issues with submodules recently ;) If there is too much overhead, raw file is OK. Thanks!

So in this workflow what we will need to do is to pull the updated version of the library file manually when the new release arrives.