Qbox-project / qbx_cityhall

GNU General Public License v3.0
11 stars 17 forks source link

Fix id card/licenses not displayed #15

Closed mockdot closed 10 months ago

mockdot commented 11 months ago

Description

Since qbx-cityhall code has changed and we're now verifying the metadata and item with the same value, it will not display. Added an item line on config and provided the name to requestId netevent.

Checklist

BerkieBb commented 11 months ago

Some things wrong with this PR:

mockdot commented 11 months ago

From my understanding, the name that it is triggering at https://github.com/Qbox-project/qbx-cityhall/blob/45c92ccef3b024c580e02a6cadd0c49f8801918e/client/main.lua#L46 is the one taken from https://github.com/Qbox-project/qbx-cityhall/blob/45c92ccef3b024c580e02a6cadd0c49f8801918e/config.lua#L17, which you define as "id_card", "driver_license" and "weaponlicense".

Now if the above name does not align with the metadata name https://github.com/Qbox-project/qbx-core/blob/334ecbb3c71d6e2bfa1192c89eaaaf1c0a4efac7/server/player.lua#L116 the license will not show, my above fix is so that we can keep the metadata name simple on core yet display it here as we want.

BerkieBb commented 11 months ago

Makes sense

BerkieBb commented 11 months ago

At line 102-104 are 3 references to item still btw