Qbox-project / qbx_core

http://qbox-project.github.io
Other
46 stars 109 forks source link

refactor: vehicle props as statebag #412

Closed solareon closed 3 months ago

solareon commented 3 months ago

Description

Vehicle props are sadly a client side thing. This change moves the logic from a callback to a statebag which runs a loop on any client within scope to set the props on a vehicle. Extensive testing has shown this is the best method of ensuring that if you ask for a blue car with a wing that you get a blue car with a wing no matter who is zipping by at 400mph or if your client/server is a potato.

Fixes #316

Credit @FjamZoo for the ox_core version of this

Checklist

jnccloud commented 3 months ago

Does this still require modification of ox_lib (uncommenting a few lines as mentioned in #316)?

solareon commented 3 months ago

Does this still require modification of ox_lib (uncommenting a few lines as mentioned in #316)?

@jnccloud No this moves the modification into the core while still using the ox_lib functionally to do the actual prop settings