search

Qbox-project / qbx_core

http://qbox-project.github.io
Other
46 stars 109 forks source link

[REQUEST] Keys Core Commands #420

Closed MrNewb closed 3 months ago

MrNewb commented 3 months ago

The problem

Typical key systems store a table and I understand why this was done this way but to discourage core edits can you pass the entity and then pull the plate later.

https://github.com/Qbox-project/qbx_core/blob/8f88f1cc1ccba23bef784e39ae5fa9abd9e7409f/server/commands.lua#L160

Ideal solution

https://github.com/Qbox-project/qbx_core/blob/8f88f1cc1ccba23bef784e39ae5fa9abd9e7409f/config/server.lua#L130

This line to pass the entity and then pull the plate in https://github.com/Qbox-project/qbx_core/blob/8f88f1cc1ccba23bef784e39ae5fa9abd9e7409f/config/server.lua#L130 after its been passed, this gives freedom and keeps the core from being edited to get a value we already had

Alternative solutions

Not doing it and making me sad

Additional context

This is motivated by my own interest's in compatibility.

Manason commented 3 months ago

It's a bit difficult to understand this. If it's a one line change can you make a PR?

void-hub-scripts commented 3 months ago

![Uploading John-F.-Kennedy-PNG-HD-Isolated-2230274760.png…]()

MrNewb commented 3 months ago

Ty, Solareon. I was worried id break some external script to the core but your approach is solid. -- Resolved