Qbox-project / qbx_core

http://qbox-project.github.io

Other

46 stars 109 forks source link

refactor(client/server): Reintroduce Bucketing and Release streamingRequest #445

Closed googleoblivion closed 2 months ago

googleoblivion commented 2 months ago

Description

This adds back in bucketing to internal multicharacter, creating a callback to change player bucket. Refactors the use of bucket native to use internal SetPlayerBucket function. Finally releases a model request not being released after use.

226

Checklist

[x] I have personally loaded this code into an updated Qbox project and checked all of its functionality.
[x] My pull request fits the contribution guidelines & code conventions.

Manason commented 2 months ago

Can you double check that this doesn't assert in-game? Last time we had issues with the native, but I believe a subsequent server artifact corrected those.

mafewtm commented 2 months ago

Once its checked we can merge this

FjamZoo commented 2 months ago

Can you double check that this doesn't assert in-game? Last time we had issues with the native, but I believe a subsequent server artifact corrected those.

yes its been fixed