feat(server): live database updates

Qbox-project / qbx_core

http://qbox-project.github.io

Other

45 stars 109 forks source link

feat(server): live database updates #460

Open BerkieBb opened 2 months ago

BerkieBb commented 2 months ago

Description

Adds small live database updating as opposed to big periodic updates.

Checklist

[x] I have personally loaded this code into an updated Qbox project and checked all of its functionality.
[x] My pull request fits the contribution guidelines & code conventions.

BerkieBb commented 2 months ago

Read through it and it looks fine to me. Is this something you’d want others to test before approving?

Would be nice, tested it myself on a one person server, so maybe not realistic

Randolio commented 2 months ago

I don’t have an active qbox live server. I think @solareon might though

solareon commented 2 months ago

I don’t have an active qbox live server. I think @solareon might though

Yeah I got one of those. I'm in the middle of the Atlantic Ocean for a few weeks so won't be able to test for a bit.

jellyton255 commented 1 month ago

Just out of curiosity, why is this preferred over the current solution, updating the data to the database in bulk on a timer?

Manason commented 1 month ago

Just out of curiosity, why is this preferred over the current solution, updating the data to the database in bulk on a timer?

When we bulk write we write all columns, even if only changing one columns value. This PR should improve database performance by making writes smaller. If we find that bulk writes are preferred then we should implement that in the storage layer using a buffer which lets us control the batch size to find the ideal numbers.