QeelwaEtech / omnifaces

Automatically exported from code.google.com/p/omnifaces
0 stars 1 forks source link

Make more elements from web.xml available in WebXml #140

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
org.omnifaces.config.WebXml currently provides access to several, but not all, 
element from web.xml that the current versions of the Servlet API do not 
provide access to.

It would be nice to implement the yet missing (useful) elements, such as 
security-constraint and welcome-file-list.

Some thought should be given whether complex elements like data-source are also 
needed (probably not, and this one is extra complex since it has a mirroring 
annotation).

For security-constraints, it might be handy to pair this with some utility 
methods such as hasUserAccessToUrl().

Original issue reported on code.google.com by arjan.tijms on 13 Feb 2013 at 6:13

GoogleCodeExporter commented 9 years ago

Original comment by balusc on 14 Feb 2013 at 2:32

GoogleCodeExporter commented 9 years ago
Added WebXml#getWelcomeFiles() and #getSecurityConstraints().

- 
http://code.google.com/p/omnifaces/source/detail?r=6c69d44a889e68d2cda23735cd9f4
088a1a6a21f
- 
http://code.google.com/p/omnifaces/source/detail?r=a465a13890fae4b172a42ecbcf60d
7e9168af8f7

TODO: utility methods. I don't think that WebXml is the right place for that. A 
separate utility class like Users or Roles is a better suit.

Original comment by balusc on 14 Feb 2013 at 7:53

GoogleCodeExporter commented 9 years ago
Improved #getSecurityConstraints() and added #isAccessAllowed(url,role). I've 
put the method on WebXml anyway.

- 
http://code.google.com/p/omnifaces/source/detail?r=33418d80c62095bfbfd430f4a9ab1
c0bf9ffddfd

Original comment by balusc on 19 Feb 2013 at 2:28