QeelwaEtech / omnifaces

Automatically exported from code.google.com/p/omnifaces
0 stars 1 forks source link

Servlet 3.0 dependency in FacesViewsForwardingFilter #143

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Line 70: 
filterConfig.getServletContext().getFilterRegistration(FacesViewsForwardingFilte
r.class.getName())

getFilterRegistration() method requires Servlet 3.0.

Original issue reported on code.google.com by Marcin.Kuthan on 20 Feb 2013 at 8:08

GoogleCodeExporter commented 9 years ago
You're right, I unfortunately overlooked this (we don't always fully test with 
Servlet 2.5, see also 
http://code.google.com/p/omnifaces/wiki/JavaEE5and6Compatibility).

Thanks for reporting!

Original comment by arjan.tijms on 20 Feb 2013 at 3:29

GoogleCodeExporter commented 9 years ago
You are welcome. 

Unfortunately my production runtime is JBoss 5, there are plans to migrate 
Jboss 6 this year. Corporate reality :-( 

Original comment by Marcin.Kuthan on 20 Feb 2013 at 7:30

GoogleCodeExporter commented 9 years ago
JBoss 5 is rather old, I hope you get the opportunity to upgrade to JBoss EAP 
6, since JBoss AS 6 is still quite old (JBoss' version numbering can be a bit 
confusing).

Anyway, I fixed calling the unsupported method for Servlet 2.5 in 
http://code.google.com/p/omnifaces/source/detail?r=68756f7644f1a2d0099a6387ef613
55a8b6d8f5a

The fix is also in the latest 1.4-SNAPSHOT on Maven.

I quickly tested with Tomcat 1.6. The initialization now passes and I could 
request a "localhost:8080/testapp/test" page correctly. If you're able to test 
the snapshot and still encounter problems just let us know. It shouldn't be too 
long now before we release 1.4.

Original comment by arjan.tijms on 22 Feb 2013 at 12:05

GoogleCodeExporter commented 9 years ago

Original comment by arjan.tijms on 24 Feb 2013 at 7:41