QeelwaEtech / omnifaces

Automatically exported from code.google.com/p/omnifaces
0 stars 1 forks source link

f:param with converter #146

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
In respect to this question, I don't know if you read my comment.

http://stackoverflow.com/questions/7766933/jsf-converter-for-fparam

Without a converter on f:param, the property converter logic is used in two 
places.

The converter for the receiver 'f:viewParam' is using the converter logic to 
convert from String to Object but the sender 'f:param' has no converter tag 
that automatically uses the Object to String conversion method.

So the same logic must be present in the converter used at '<f:viewParam 
name="product" converter="Converter"/>' and duplicated be used at every usage 
of '<f:param name="product" value="#{bean.product.id}"/>

If the conversion now would stop using id and for example use gtin 
(global-trade-item-number) the logic would have to be changed once in the 
converter and in every f:param of the application!

Original issue reported on code.google.com by releases...@googlemail.com on 26 Feb 2013 at 12:25

GoogleCodeExporter commented 9 years ago
Makes fully sense.

Original comment by balusc on 26 Feb 2013 at 10:59

GoogleCodeExporter commented 9 years ago
Added: 
http://code.google.com/p/omnifaces/source/detail?r=75a7442e124236061deb1c554766f
5f27bf79524

You can find attached the current snapshot with the new o:param. Let me know if 
it does the job for you.

Original comment by balusc on 26 Feb 2013 at 11:21

Attachments:

GoogleCodeExporter commented 9 years ago
Works perfectly, great thanks :)

Original comment by releases...@googlemail.com on 1 Mar 2013 at 12:57