search

Qendolin / better-clouds

Beautiful clouds in touch with the vanilla style
https://modrinth.com/mod/better-clouds
Mozilla Public License 2.0
35 stars 13 forks source link

Compatibility with Head in the Clouds (Sunshine above the clouds) #81

Open HB-Stratos opened 2 months ago

HB-Stratos commented 2 months ago

Is your feature request related to a problem? Please describe.

I recently tested Head in the Clouds ( https://modrinth.com/mod/head-in-the-clouds ), a mod that makes the sun shine when above the clouds. I love the effect when flying through the clouds from under the rain. However, from above the effect looks very weird and the illusion is quickly broken as one can see clearly below the clouds where there previously was dark fog. This is especially impacted as cloud density above the clouds reduces to sunny day levels even if there is a thunderstorm underneath.

https://github.com/Qendolin/better-clouds/assets/56313836/4b73ea27-f6f2-46d6-9b26-e1e5de6e7297

Describe the solution you'd like

I think it might work if Better Clouds was able to recognize that the weather was set to rain / thunder even if the world is currently showing sunlight above the clouds. If this state was recognized the cloud density below the player should match the density the player would be seeing from underneath in the bad weather. This should help to mask the effect of suddenly having good weather below the clouds when above them. Cloud Density from below: image Cloud Density from above: 2024-04-22_23 05 02 These two densities should ideally match to mask the effect of rain not rendering under clouds.

Describe alternatives you've considered

I haven't been able to come up with any

Additional context

https://github.com/Qendolin/better-clouds/issues/59 I found this and see that some level of compatibility was already added, presumably to make the weather change work at all based on height. I believe my issue here still remains valid as it is an additional enhancement on top of this.

Qendolin commented 2 months ago

While this is valid issue, there is not much that I can do. The Head In the Clouds mod simply sets the weather to sunny when above the clouds. There is not really a way for me to detect that it should still be dense, rain clouds underneath. Unless HITC adds an api for mod compatibility I really can't do much else.

HB-Stratos commented 2 months ago

While this is valid issue, there is not much that I can do. The Head In the Clouds mod simply sets the weather to sunny when above the clouds. There is not really a way for me to detect that it should still be dense, rain clouds underneath. Unless HITC adds an api for mod compatibility I really can't do much else.

DaFuqs has replied to my issue over there, communicating that they will add such an API. So this may just work.

DaFuqs commented 2 months ago

I added a small API package via https://github.com/DaFuqs/HeadInTheClouds/commit/9ed121462ee0e46fe4a3e3d2cc57b488bc4de128 for mc 1.20.1-1.20.6. If you need anything lmk