search

Qeole / Enlight

Firefox add-on providing syntax highlighting for raw code, based on the highlight.js project.
Mozilla Public License 2.0
42 stars 2 forks source link

Line Numbers #1

Closed ericfowler303 closed 9 years ago

ericfowler303 commented 9 years ago

I really enjoy having this auto-enabled as it works quite well. Would it be possible to get lined numbers added as an option when viewing a highlighted page?

Qeole commented 9 years ago

This sounds like a good idea. Highlight.js has some support for it but not in the master branch, and has no plan to merge it for now it seems. But It should not be too hard to reuse their code in the add-on I think. I'm a bit busy right now but I'll try to give it a shot in a few days/weeks.

Qeole commented 9 years ago

@ericfowler303: fixed with commit 531bf3671818c1333f204ec23700e1692393a43e :-). There's another thing I want to do before submitting again to AMO (namely: switching from cfx to jpm building tool), but you can test the version from this repo meanwhile. I added it as a check-in option, so you have to manually activate line numbers in the add-on prefs.

ericfowler303 commented 9 years ago

Great stuff! I just tested it out and it works great with the pref. This was done in the currently nightly of course, but I'm sure it will be fine in other versions.

Qeole commented 9 years ago

Glad to hear that :-). I pushed it to AMO tonight, I hope it will be accepted soon and land for all users. Thanks for feedback!

Qeole commented 9 years ago

For your information, it's just been released on addons.mozilla.org (version 1.9.0 of the add-on) if you prefer the “official” reviewed version.