search

Qeole / colorediffs

Thunderbird extension to colorize code diffs in messages.
Mozilla Public License 2.0
25 stars 5 forks source link

Version 2.1.1 does not work on Thunderbird 78.14.0 #105

Open guilhermepiccoli opened 2 years ago

guilhermepiccoli commented 2 years ago

Hey all, first I'd like to thank you for the very interesting add-on - this is pretty useful!

So, when checking plain/text patches (sent with git send-email), I cannot see the colored diffs. I'm using Thunderbird 78.14 (from Ubuntu 20.04), but I don't have any other kind of patches to compare, I only use git send-email and check kernel lists, so no Github patches for example.

Is the add-on supposed to work with plain/text messages? Thanks!

Qeole commented 2 years ago

Hi, and thank you for the report! Yes, the add-on is supposed to work on plain text emails sent with git, it's the primarily use case (for me, at least).

I have not tested on Thunderbird 78.14. The add-on should work as expected on 78.4, on some later versions, and then on 91+, but I have not tested all versions in between.

What version of the add-on do you run? It should be 2.1.1? If this is the case, do you have a chance to try 2.2.0, to see if it works (not sure if the add-on repository lets you do it, you can install manually from this repo otherwise)? I remember we had to update something between Thunderbird 78.* and 91, maybe the change in Thunderbird that caused this was backported to the 78 branch?

Otherwise I'll give a try myself on 78.14 when I have a moment.

guilhermepiccoli commented 2 years ago

Hi @Qeole , thanks a lot for your prompt response!

So, I was using 2.1.1 as you said...I removed that, and tried to install 2.2.0, the XPI from repo. But..TB didn't allow me, claiming it's not compatible. And that even after I turn off the "extensions.strictCompatibility" config in the advanced editor.

Last resort was to hack the manifest json inside the xpi, and set the min version to 78 (it was set to 91). With that, I could install the add-on, but it still doesn't work. So, I think it's not compatible anymore with versions < 91, right?

Thanks again!!

guilhermepiccoli commented 2 years ago

And guess what? I've just updated TB, running 91 now..and it's working like a charm! I'm using the version from the add-on repository, it seems to be 2.2.0 ... congrats, the extension is very nice and useful =)

Cheers!

Qeole commented 2 years ago

Great news, thanks for testing and letting me know!!

I also appreciate a lot the feedback. I tried to change the compatibility of version 2.1.1 to reflect that it does not work on Thunderbird, v78.14, but the list doesn't have all 78.* versions, and I prefer to have a few users hitting this issue rather than to take the risk to disable the add-on for Thunderbird versions where it should work.

Given that the latest version of the add-on works on the current stable version of Thunderbird, I won't spend time investigating the issue. But I'll leave this issue open for reference.

guilhermepiccoli commented 2 years ago

Thanks! I agree with you, better have some users that may use it on versions prior to 91 than nobody heh Cheers!