search

Qeole / colorediffs

Thunderbird extension to colorize code diffs in messages.
Mozilla Public License 2.0
25 stars 5 forks source link

Add IntelliJ Light style. #107

Closed laggarcia closed 2 years ago

laggarcia commented 2 years ago

Adds IntelliJ Light style to the list-styles.js. This style has been introduced in highlight.js and need to be listed here in order to properly build the project.

laggarcia commented 2 years ago

Ops, yes, I can do that. But, because of my lack of GitHub PR skills, I am not being able to do this here. I'll close this PR and open a new one with the proper patch.

Qeole commented 2 years ago

No problem! Some hints for next time:

  1. Edit your file
  2. Amend your last commit (git commit --amend)
  3. Force-push

Or if you have several commits to deal with, git rebase --interactive lets you select the commits to pick, drop, edit, etc. Needs a bit of practice, but this one is super useful.

laggarcia commented 2 years ago

Well, that was what I did! However, after the force-push GitHub was complaining that the PR was not referencing a valid commit anymore. Anyway, I should probably read the docs. :smile: Thanks for the tip anyway!

Qeole commented 2 years ago

GitHub was complaining that the PR was not referencing a valid commit anymore

Could be that you somehow amended one of the commits before yours; not by changing the code, just by modifying somehow (during a rebase) the commit object internal to Git; if that was the case, GitHub would likely complain about not being able to match the parent for your commit to one of the commit it knows in the branch. But then I'm not 100% sure of it.

laggarcia commented 2 years ago

Ah, that makes sense. I had rebased to the new master with the background.html file.