search

Qeole / colorediffs

Thunderbird extension to colorize code diffs in messages.
Mozilla Public License 2.0
24 stars 5 forks source link

Fix invisible checkboxes #116

Closed Grillo-0 closed 12 months ago

Grillo-0 commented 12 months ago

The checkboxes would not change the color and have the check icon when selected. Removing the line that messes with the appearance attribute of the checkboxes appears to solve the issue.

Qeole commented 12 months ago

Thanks for investigating and submitting the PR! This is clearly an improvement, although it doesn't render perfectly with dark backgrounds. This is not because of your PR, but rather because the CSS in common.inc.css is no longer in sync with Thunderbird's version (it's been nearly 3 years since I copied the file).

So instead, I would be tempted to update the whole file - this is what I do in PR https://github.com/Qeole/colorediffs/pull/117. It fixes how checkboxes are displayed for me, would you be willing to test it on your side?

Grillo-0 commented 12 months ago

It's working on my side. It's even better with the new visuals :D.

For me, the #117 PR is good for now.

For development's sake, I will drop a comment about this approach of copying common.inc.css from Thunderbird in the future.

Grillo-0 commented 12 months ago

I will close this PR on the benefit of https://github.com/Qeole/colorediffs/pull/117.