search

Qeole / colorediffs

Thunderbird extension to colorize code diffs in messages.
Mozilla Public License 2.0
24 stars 5 forks source link

Update options CSS #117

Closed Qeole closed 12 months ago

Qeole commented 12 months ago

We introduced a copy of upstream CSS nearly three years ago; it changed quite a lot since then, and some elements do no longer render properly in accordance with the rest of Thunderbird's style (see PR #116). Let's update the file by copying the current version [0], trimming down unused items, and replacing :root with body, as we did already for the previous version.

[0] changeset 636997:517d690052a2)

Qeole commented 12 months ago

Linking https://bugzilla.mozilla.org/show_bug.cgi?id=1678150 here so I don't lose it again.

Grillo-0 commented 12 months ago

This is great for now :).

I just don't think this approach of copying this CSS file from Thunderbird is good. Having to do that update every time is a bit cumbersome.

I never developed add-ons for Thunderbird, maybe there is a better way of doing that. If you have any ideas I'm willing to do them ;).

Thank you for your time maintaining this project!

Qeole commented 12 months ago

This is great for now :).

I just don't think this approach of copying this CSS file from Thunderbird is good. Having to do that update every time is a bit cumbersome.

Totally agree. I'd love to avoid that, too, but this is the best solution I've found so far to get a consistent visual on the option page.

I never developed add-ons for Thunderbird, maybe there is a better way of doing that. If you have any ideas I'm willing to do them ;).

I've hacked a few things for Thunderbird, but it could well be that there's a better solution and I don't know about it. I'm not well versed into all the possibilities for add-ons.

The thing is that it's nearly possible to include the file from Thunderbird directly, without having to copy/embed it in the add-on. Last time I tried, it's just that the CSS selectors :root wouldn't work. Replacing them with body does. I'm no CSS expert but I suspect there should be a way to have this work both in Thunderbird and from the add-ons; I filed a bug (see link above), but this hasn't got any traction over the three years it's been open.

At least, doing an update of the file once every three years is not that much work. But yeah, I hope that eventually this issue is solved and we can just include Thunderbird's CSS for the option page.

Thank you for your time maintaining this project!

I need it to work, too :)