Qeole / colorediffs

Thunderbird extension to colorize code diffs in messages.
Mozilla Public License 2.0
25 stars 5 forks source link

links in colored diff are not highlighted nor clickable #118

Closed Mrten closed 1 year ago

Mrten commented 1 year ago

Links that are clickable in the 'normal' plain text view aren't anymore if colored diffs decides to 'color' the message:

Author: XXXX
Date: XXXX
New Revision: XXXX
URL: https://xxxxx.xx/xxxx?id=Xxxx

Log:
[xx:xxxx] xxxxxxxxxx

Modified:
   web/xxxxxx.xxx/xxxx/user_statistics.php

Modified: web/xxxxxxx.xxx/xxxx/user_statistics.php
==============================================================================
--- web/xxxxxxx.xxx/xxxx/user_statistics.php    Tue Sep 12 14:23:20 2023    (r54678)
+++ web/xxxxxxx.xxx/xxxx/user_statistics.php    Tue Sep 12 14:54:44 2023    (r54679)
@@ -1,5 +1,7 @@
 <?php

+use·xxx\database\DB;
+
 require·'dbconnect.php';
@@ -11,8 +13,27 @@
 $htTitle·=·"User·Statistics";
 require·'header.php';

After 'URL' there is a link to an internal bugtracker which is clickable without the addon activated.

Qeole commented 1 year ago

Thanks for the report! Could you please try with the current version from this repo? This seems to be a duplicate of #104 and should have been fixed with https://github.com/Qeole/colorediffs/commit/2c2be9319d289484f561f614b0207d2eb54bc246 (although it looks like I never cut a new version after that).

Mrten commented 1 year ago

I agree this seems to be the same problem! Didn't go looking for closed issues, sorry.

Anyway, after a zip download, amake gave me a couple of warnings:

[WARNING] Found missing CSS style: "panda-syntax-dark".
[WARNING] Found missing CSS style: "panda-syntax-light".
make: *** [check_css_list] Error 1

but make xpi worked (I edited the version in manifest.json to be sure)

Looking at a diff it seems to work, thanks!

Qeole commented 1 year ago

I tagged and published a new version a few days ago, so the fix should now be included in the version you get from https://addons.thunderbird.net (or via automatic updates).

Mrten commented 1 year ago

😄 thank you for doing that!