colorediffs does not color diffs in encoded messages

Qeole / colorediffs

Thunderbird extension to colorize code diffs in messages.

Mozilla Public License 2.0

25 stars 5 forks source link

colorediffs does not color diffs in encoded messages #25

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago

colorediffs does not color diffs in encoded messages, e.g. if messages are 
encoded as base64 and sent as multipart/alternative - see attached 
screenshot colorediffsfailed4encoded.jpg.

1. Receive forwarded diff with from SVN notification that is encoded as 
multipart/alternative by base 64 
or
2. Try to view colored diff , e.g. in default "unified" view and see that 
diff part of the message is not highlighted as expected (see screenshot)

Product version: colored_diffs-0.4.1-tb.xpi over Mozilla Thunderbird 
2.0.0.6 (20070728)
OS: MS Windows XP Proffesional SP2

Does not work for all my SVN notifications...
A sample message is attached as "FW_SVN_notification.eml"

Original issue reported on code.google.com by salmira on 17 Sep 2007 at 10:58

Attachments:

GoogleCodeExporter commented 9 years ago

Thanks for making me aware of this, I'll fix it ASAP.

Original comment by vadim.at...@gmail.com on 17 Sep 2007 at 11:16

Changed state: Accepted
Added labels: Priority-Critical, Milestone-Release0.5
Removed labels: Priority-Medium

GoogleCodeExporter commented 9 years ago

Found a problem: as it is multipart message there are plain text content and 
html
one. Thunderbird prefers html over text but extension doesn't support it yet. 
As a
workaround you could make Thunderbird to use plain text (View -> Message Body 
As ->
Plain Text). In the mean time I'll try to fix the bug.

Original comment by vadim.at...@gmail.com on 17 Sep 2007 at 3:16

GoogleCodeExporter commented 9 years ago

Tech note to myself: if div with moz-text-html class is found try to set
mailnews.display.prefer_plaintext to true and reload message. Don't forget to 
restore
configuration value afterwards.

Original comment by vadim.at...@gmail.com on 17 Sep 2007 at 3:48

GoogleCodeExporter commented 9 years ago

Thanks for suggestion! And looking forward for the fix.

Original comment by salmira on 19 Sep 2007 at 10:08

GoogleCodeExporter commented 9 years ago

Fixed in CVS, new version is planned in a few days and I'm not going to close 
the bug
till then.

Original comment by vadim.at...@gmail.com on 30 Sep 2007 at 1:14

GoogleCodeExporter commented 9 years ago

Fixed in 0.4.2

Original comment by vadim.at...@gmail.com on 8 Oct 2007 at 10:31

Changed state: Fixed