Qeole / colorediffs

Thunderbird extension to colorize code diffs in messages.
Mozilla Public License 2.0
25 stars 5 forks source link

Line trimming disrupts output #37

Closed GoogleCodeExporter closed 4 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Take working (unified diff) mail with blank, unchanged line as first one
of a context
2. Sign this mail with GnuPG (Enigmail) --> Lines get trimmed
3. Send to someone and view the result

What is the expected output? What do you see instead?
The parser should try to reconstruct that this blank line is a valid
(unchanged) line of the context and thus should ignore it not having a
space as first char. The actual (current) behaviour is a rewrite of the
context boundaries containing 0 lines if the trimmed line was first.

What version of the product are you using? On what operating system?
0.4.2 on Win2K with TB 2.0.0.9

Please provide any additional information below.
Maybe the parser should try to ignore minor errors on non-armorred
characters like spaces to improve interoperatibility with security tools
like GnuPG\Enigmail.

Original issue reported on code.google.com by BenBE1...@googlemail.com on 18 Nov 2007 at 2:11

GoogleCodeExporter commented 9 years ago
I couldn't really get it, could you send me an example of such behavior?

Original comment by vadim.at...@gmail.com on 18 Nov 2007 at 11:29

GoogleCodeExporter commented 9 years ago
Enigmail trims the end of lines, thus a blank unchanged line would normally be 
" "
(without the quotes). But due to the trimming only "" (without the quotes) is 
sent.
This leads to detection of this particular line as being the end of the context,
although it is not.

Original comment by BenBE1...@googlemail.com on 12 May 2008 at 2:31

GoogleCodeExporter commented 9 years ago
I'll give it a try. Though there is a lot of other work to do so don't expect 
fix soon.

Original comment by vadim.at...@gmail.com on 13 May 2008 at 8:47

Qeole commented 4 years ago

Obsoleted in v2 by c8436ddca5160c736aaf67326ccbaa08ffb01ae5.