Qeole / colorediffs

Thunderbird extension to colorize code diffs in messages.
Mozilla Public License 2.0
25 stars 5 forks source link

Links broken with certain filenames #41

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Produce a diff containing a filename with a common extension as basename
(e.g. php.php or c.php)
2. The links for this file is trashed at the first recognized extension,
all following files are ignored

What is the expected output? What do you see instead?
Expected was just normal links; but I see trashed links with parts of HTML
exposed instead (Might be XSS-able???).

What version of the product are you using? On what operating system?
0.4.2

Please provide any additional information below.
GeSHi produces such diffs regularly as most files are named by languages
and thus incidentially equal some common extensions.

Original issue reported on code.google.com by BenBE1...@googlemail.com on 12 May 2008 at 2:25

GoogleCodeExporter commented 9 years ago
Could you please attach broken mail as eml file here? Or if it is not 
appropriate
just forward it to me?

Original comment by vadim.at...@gmail.com on 13 May 2008 at 8:45

GoogleCodeExporter commented 9 years ago
In the file attached look at the line where php.php is changed.

Looks like this for me:
Modified Paths:
--------------
    *branches/RELEASE_1_0_7_STABLE/geshi-1.0.X/src/contrib/example.php*
    *branches/RELEASE_1_0_7_STABLE/geshi-1.0.X/src/docs/CHANGES*
    *branches/RELEASE_1_0_7_STABLE/geshi-1.0.X/src/geshi/glsl.php*

*branches/RELEASE_1_0_7_STABLE/geshi-1.0.X/src/geshi/php*.php'>branches/RELEASE_
1_0_7_STABLE/geshi-1.0.X/src/geshi/php.php
    branches/RELEASE_1_0_7_STABLE/geshi-1.0.X/src/geshi.php

With something like *Link* being clickable.

Original comment by BenBE1...@googlemail.com on 16 May 2008 at 7:38

Attachments:

GoogleCodeExporter commented 9 years ago
Thanks, found and fixed. But you'll have to wait for a new version and that's 
not
going to happen for a next couple of months...
I'll leave the bug open until the fix would be go public.

Original comment by vadim.at...@gmail.com on 16 May 2008 at 11:55

GoogleCodeExporter commented 9 years ago
Issue 48 has been merged into this issue.

Original comment by vadim.at...@gmail.com on 11 Dec 2008 at 11:47

GoogleCodeExporter commented 9 years ago
Issue 49 has been merged into this issue.

Original comment by vadim.at...@gmail.com on 11 Dec 2008 at 11:48

GoogleCodeExporter commented 9 years ago

Original comment by vadim.at...@gmail.com on 15 Dec 2008 at 11:11

GoogleCodeExporter commented 9 years ago
Fixed in 0.5.159

Original comment by vadim.at...@gmail.com on 28 Dec 2008 at 5:19