search

Qeole / colorediffs

Thunderbird extension to colorize code diffs in messages.
Mozilla Public License 2.0
25 stars 5 forks source link

First chunk not colored #42

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. Read any merge email on the bazaar mailing list
2. Note how the first hunk is never highlighted

What is the expected behavior? What do you see instead?

I'd expect the first hunk to be highlighted along with the rest of them.
This happens in all view types. Not sure if it's a problem with how bzr
send formats the email, or if it's a corner case not handled in the Colored
Diffs plugin's parsing. Either way, this seems like a good place to start
getting it resolved.

What version of the product are you using? On what operating system?

0.4.2. I've noticed this from both Linux and Vista. 

Please provide any additional information below.

If you are not on the bzr mailing list please let me know and I would be
happy to forward you an example email that can be used to reproduce this
problem.

Original issue reported on code.google.com by pickscr...@gmail.com on 26 May 2008 at 2:29

GoogleCodeExporter commented 9 years ago 
Yep, I'm not in bzr mailing list so if you could save one of email as eml file 
and
attach to this bug or just send me it directly I would really appreciate it.

Original comment by vadim.at...@gmail.com on 27 May 2008 at 9:47

GoogleCodeExporter commented 9 years ago 
Attached a sample email. which seems suitable as it's fairly short and contains 
three
hunks.

Hope this helps!

Original comment by pickscr...@gmail.com on 27 May 2008 at 1:11

Attachments:

GoogleCodeExporter commented 9 years ago 
Oh, yes, it's a really strange corner case. There is no empty line between log
message and patch so extension just couldn't recognize where one ends and other
begins. I'll see what I can do about it, thanks for submitting.

Original comment by vadim.at...@gmail.com on 28 May 2008 at 3:17

GoogleCodeExporter commented 9 years ago 
Fixed in 0.5.159

Original comment by vadim.at...@gmail.com on 28 Dec 2008 at 5:20