search

Qeole / colorediffs

Thunderbird extension to colorize code diffs in messages.
Mozilla Public License 2.0
25 stars 5 forks source link

some email including patch may cause colordiffs deadly loop #51

Closed GoogleCodeExporter closed 3 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. enable colordiffs 0.5.171 with unified format
2. got the email like attached:
3. the mail didn't be loaded, and got a warning mesg "A script on this page
may be busy, or it may have stopped responding. You can stop the script
now, or you can continue to see if script will complete". If choosing
"continue", it start the loop again unless I choose "stop script".

What is the expected behavior? What do you see instead?
no such deadly loop. The mail is loaded with right diff format.

What version of the product are you using? On what operating system?
0.5.171 on gentoo linux system. 

Please provide any additional information below.
But 0.4.2 is fine

Please also attach a broken mail as an eml file to this bug. It will really
help me to fix it faster.

Original issue reported on code.google.com by zhaig...@gmail.com on 20 Mar 2009 at 8:10

Attachments:

GoogleCodeExporter commented 9 years ago 
Hm, I will fix the freezing but I doubt this patch will be colored. Too much 
text
around, I don't know any good way to distinguish it from the code.

Original comment by vadim.at...@gmail.com on 20 Mar 2009 at 8:19

GoogleCodeExporter commented 9 years ago 
No color is better than freezing:)
You know, current timeout is 20s, so I have to wait for the freezing 
thunderbird...

Original comment by zhaig...@gmail.com on 20 Mar 2009 at 8:33

GoogleCodeExporter commented 9 years ago 
This same issue happens to me occasionally.
Thunderbird 2.0.0.2[2|3]
Windows 32bit XP SP3

I've attached en email which triggers the deadlock and has a very short email 
body.

Please Note that opening the attached saved email in Thunderbird won't cause the
issue, but receiving the email body through the mail and opening the email as 
normal
will cause it - coloreddiffs doesn't seem to be invoked on opening saved emails.

Original comment by jahboite@gmail.com on 22 Aug 2009 at 1:33

Attachments:

Qeole commented 3 years ago

Obsoleted in v2 by c8436ddca5160c736aaf67326ccbaa08ffb01ae5.