Qeole / colorediffs

Thunderbird extension to colorize code diffs in messages.
Mozilla Public License 2.0
24 stars 5 forks source link

not compatible to Thunderbird 5 #73

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. upgrade to / install TB5
2. plugin will be disabled
3. searching for updates indicates no new version

What is the expected behavior? What do you see instead?

Support for TB5 :)

What version of the product are you using? On what operating system?

Ubuntu 10.10, TB5, Colored Diffs 0.6.2010.06.25.16.16.59

Please provide any additional information below.

Please also attach a broken mail as an eml file to this bug. It will really 
help me to fix it faster.

Original issue reported on code.google.com by inlin...@gmail.com on 29 Jun 2011 at 6:57

GoogleCodeExporter commented 9 years ago
When operating TB5 with add-on compatibility check turned off, Colored Diffs 
seems to work fine. So hopefully, not much is to be done to make it officially 
compatible with TB5.

Original comment by stefan.s...@gmail.com on 29 Jun 2011 at 12:08

GoogleCodeExporter commented 9 years ago
Works as expected with Windows 7, TB 5.0 and Colordiff 0.6.2010.07.17.13.19.31
Only smilies in commit messages are displayed as image and than additional as 
plain-text.

Original comment by clus...@gmx.de on 30 Jun 2011 at 9:42

GoogleCodeExporter commented 9 years ago
When I try to install that version TB tells me it's not compatible to TB5. How 
did you get it installed?

Original comment by inlin...@gmail.com on 30 Jun 2011 at 9:48

GoogleCodeExporter commented 9 years ago
Go to Tools->Options->Advanced->Config Editor
Create a new boolean value with the name "extensions.checkCompatibility.5.0" 
and set the value to "false". Then enable Colored Diffs in the AddOns manager.

Warning: this will turn off that version-incompatible addons are automatically 
disabled for ALL addons, even if they REALLY are incompatible, so use with 
caution. Look into the AddOns manager to manually disable other incompatible 
addons.

Original comment by stefan.s...@gmail.com on 30 Jun 2011 at 3:49

GoogleCodeExporter commented 9 years ago
Disabling version compatibility testing should not be recommended especially 
when all that is needed is an update to the max version variable in the rdf 
file. This should have been fixed by now if all works as expected in TB version 
5. Its only 1 line in the rdf file guys and not even a full line.

Original comment by adamgmetzler@gmail.com on 18 Jul 2011 at 3:42

GoogleCodeExporter commented 9 years ago
I did change the maxversion to 5.* and it's working as it should. Can't see any 
issues (after 10 min of use).

Original comment by pnlars...@gmail.com on 15 Aug 2011 at 6:23

GoogleCodeExporter commented 9 years ago
And then i had to raise it to 6 to make it work with thunderbird 6 - and it 
does work.

Original comment by pnlars...@gmail.com on 16 Aug 2011 at 10:18

GoogleCodeExporter commented 9 years ago
After checking out trunk sources, patching them

Index: options.json
===================================================================
--- options.json    (revision 211)
+++ options.json    (working copy)
@@ -2,7 +2,7 @@
   "apps": [{"name": "Thunderbird",
        "aid": "{3550f703-e582-4d05-9a08-453d09bdfdc6}",
        "minVersion": "3.0a1pre",
-       "maxVersion": "3.1.*"
+       "maxVersion": "7.*"
       },
       {"name": "SeaMonkey",
        "aid": "{92650c4d-4b8e-4d2a-b7eb-24ecf4f6b63a}",

and running (Ubuntu 11.10 "Oneiric")

$ sudo apt-get install rake ruby-json-pure ruby-rubyzip2
$ mkdir ~/cc-private
$ openssl req -x509 -nodes -days 365 -newkey rsa:1024 -keyout 
~/cc-private/mykey.pem -out ~/cc-private/mycert.pem
# ...give some answers
$ rake

I wound up with a file 
google-code-build/colorediffs-0.6.2011.10.31.00.07.31.xpi which Thunderbird 
7.0.1 agreed to install. It seems to work fine after light testing.

Original comment by typr...@gmail.com on 31 Oct 2011 at 12:12

GoogleCodeExporter commented 9 years ago
Finally, someone interested enough in that project to support it :)
I'll send you the private keys so you can sign build properly, otherwise 
Thunderbird will not update it.

Original comment by vadim.at...@gmail.com on 31 Oct 2011 at 12:41

GoogleCodeExporter commented 9 years ago
Issue 74 has been merged into this issue.

Original comment by typr...@gmail.com on 31 Oct 2011 at 9:54

GoogleCodeExporter commented 9 years ago
This issue was closed by revision r212.

Original comment by typr...@gmail.com on 31 Oct 2011 at 10:05

GoogleCodeExporter commented 9 years ago
TB 8 is out now. Change of the maxVersion line to 8.* seems enough.

Original comment by jan.svi...@gmail.com on 9 Nov 2011 at 8:53

GoogleCodeExporter commented 9 years ago
Because this issue is marked as fixed, i open a new issue for TB 8:
http://code.google.com/p/colorediffs/issues/detail?id=77

Original comment by l.mone...@gmail.com on 22 Nov 2011 at 6:50