search

Qeole / colorediffs

Thunderbird extension to colorize code diffs in messages.
Mozilla Public License 2.0
24 stars 5 forks source link

Feature request: add quick links if diff has more than 1 file change #84

Open aik opened 7 years ago

aik commented 7 years ago

$subj

Qeole commented 7 years ago

Hi, and thanks! Am I correct to suppose that by adding “quick links”, you mean adding a list of modified files (with the links) similar to a ToC at the beginning of the diff for quick jumps? Or did I miss the point?

aik commented 7 years ago

No, you got it right :) A patch may change 25 files, and I only care about few - so I need a way to jump quickly to these files. I could think of a drop-down list of files where all the addon controls are ooooor replace file names in the index with clickable links (I do not know if it is doable though). By "index" I mean this:

include/sysemu/numa.h | 2 +- include/sysemu/sysemu.h | 7 ------- numa.c | 19 ++++++++++++------- vl.c | 5 ----- 4 files changed, 13 insertions(+), 20 deletions(-)

Qeole commented 7 years ago

Ok, understood. I like (more) the second idea, adding links to the names in the index. I became maintainer of this add-on some months ago, but I don't know enough of the code yet to tell how easy that would be to implement.

Also, adding features here is not at the top of my todo-list, so do not expect me to do it really soon, I'll see when I have some spare time (or if anyone else wants to give it a try, don't hesitate).

Meanwhile, thanks for the idea and for using the add-on!