search

Qeole / colorediffs

Thunderbird extension to colorize code diffs in messages.
Mozilla Public License 2.0
25 stars 5 forks source link

Showing whitespaces and changing tab size behave inproperly #86

Closed Qeole closed 6 years ago

Qeole commented 7 years ago

When trying to show whitespaces and tabs, only the first tab and first whitespace are displayed.

Similarly, only the first tab seems to change size when we modify the option.

I suspect the regex that's applied to the text to perform these modifications somehow lost its “global” flag and only applies to the first occurrence on the line. To be investigated.

Qeole commented 6 years ago

Flags as third arguments, as passed to replace() in several parts of the add-on, were a Gecko extension. Support for this was dropped for Thunderbird 49 and higher.

Fixed in dev branch. If you were to fetch it, note that this branch is not stable and history can be rewritten.

Qeole commented 6 years ago

Fixed with commit 28ce5f1a249241b7443f77067cd35b9190a8f1f4.